Update DriverOptions.java #1256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🚀 Custom chrome options added. 🐞 Fixed a issue with workingDir that mistakenly create new directories when userDataDir was defined.
ptrthomas
requested changes
Aug 17, 2020
| userDataDir = (String) options.get("userDataDir"); | ||
| disableNotifications = get("disableNotifications", false); | ||
| userAgent = get("userAgent", null); | ||
| String place = get("userDataDir", null); |
There was a problem hiding this comment.
I wanted user to provide null in which case chrome would use system defaults
and not providing would default to workingDir
will this work the same way
There was a problem hiding this comment.
Leaving workingDir like that, will create countless 'chrome_1234567890' folders inside target with zero content.
Beacause Command class will check if it exists and create one if not.
This way, workingDir and userDataDir are the same.
luizvaz
commented
Aug 17, 2020
Comment on lines
+84
to
+85
| public final boolean disableNotifications; | ||
| public final String userAgent; |
There was a problem hiding this comment.
You can ignore that!
luizvaz
commented
Aug 17, 2020
Comment on lines
+172
to
+173
| disableNotifications = get("disableNotifications", false); | ||
| userAgent = get("userAgent", null); |
ptrthomas
added a commit
that referenced
this pull request
Aug 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Custom chrome options added.
🐞 Fixed a issue with workingDir that mistakenly create new directories when userDataDir was defined.
Description
Thanks for contributing this Pull Request. Make sure that you submit this Pull Request against the
developbranch of this repository, add a brief description, and tag the relevant issue(s) and PR(s) below.